Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: #1 Modal 전역 상태관리 #31

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

shlee9999
Copy link
Collaborator

@shlee9999 shlee9999 commented Nov 21, 2024

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #1

Modal 전역상태로 관리하여 편리하게 켜고(pushModal) 끌 수(popModal) 있습니다.

🖼️ Screenshots

@shlee9999 shlee9999 linked an issue Nov 21, 2024 that may be closed by this pull request
@shlee9999 shlee9999 enabled auto-merge November 21, 2024 03:16
Copy link

⚡ Lighthouse Report

Category Score
🟢 Performance 94
🟢 Accessibility 100
🟢 Best Practices 100
🟢 SEO 100

Detailed Metrics

Metric Value
🟢 First Contentful Paint 1.5 s
🟠 Largest Contentful Paint 2.9 s
🟢 Total Blocking Time 140 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 1.5 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@shlee9999 shlee9999 self-assigned this Nov 21, 2024
@shlee9999 shlee9999 closed this Nov 21, 2024
auto-merge was automatically disabled November 21, 2024 06:34

Pull request was closed

@shlee9999 shlee9999 reopened this Nov 21, 2024
kimjuyoung78
kimjuyoung78 previously approved these changes Nov 21, 2024
Copy link
Collaborator

@kimjuyoung78 kimjuyoung78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

합격 드리겠습니다.

wonill
wonill previously approved these changes Nov 21, 2024
@shlee9999 shlee9999 dismissed stale reviews from wonill and kimjuyoung78 via 5a40983 November 21, 2024 08:43
wonill
wonill previously approved these changes Nov 21, 2024
@shlee9999 shlee9999 merged commit 983f403 into develop Nov 21, 2024
1 check passed
@github-actions github-actions bot deleted the 1-feature/global-modal-management branch November 29, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Modal 전역 상태 관리
3 participants